Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump crddiff to v0.8.0 #1040

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Conversation

ulucinar
Copy link
Collaborator

@ulucinar ulucinar commented Dec 22, 2023

Description of your changes

Relevant PR: #1037

This PR bumps crddiff to v0.8.0 and adds the --enable-upjet-extensions command-line option while running it. Please see the description in upbound/official-providers-ci#160 for more details.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

- Enable upjet extensions for crddiff

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
@ulucinar
Copy link
Collaborator Author

Because we are bumping the version of the uptest binary:
/test-examples="examples/ec2/vpc.yaml"

Copy link
Collaborator

@mergenci mergenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulucinar ulucinar merged commit e481131 into crossplane-contrib:main Dec 22, 2023
10 checks passed
@ulucinar ulucinar deleted the crddiff-upjet-ext branch December 22, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants